Messages in this thread | | | Date | Thu, 11 Sep 2008 12:03:52 +0200 | From | "Marcin Obara" <> | Subject | Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27 |
| |
2008/9/11 Andrew Morton <akpm@linux-foundation.org>: > On Thu, 11 Sep 2008 00:11:37 +0200 > Jiri Slaby <jirislaby@gmail.com> wrote: > >> Hi, >> >> is it possible to push >> tpm-correct-tpm-timeouts-to-jiffies-conversion.patch >> (the patch header follows) into 2.6.27, please? > > Sure. > >> From: Marcin Obara <marcin_obara@users.sourceforge.net> >> >> This patch fixes timeouts conversion to jiffies, by replacing >> msecs_to_jiffies() calls with usecs_to_jiffies(). According to TCG TPM >> Specification Version 1.2 Revision 103 (pages 166, 167) TPM timeouts and >> durations are returned in microseconds (usec) not in miliseconds (msec). >> >> Signed-off-by: Marcin Obara <marcin_obara@users.sourceforge.net> >> Cc: Marcel Selhorst <tpm@selhorst.net> >> Cc: Kylene Jo Hall <kjhall@us.ibm.com> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > > Why? I wasn't aware that this fixed anything which anyone had observed > (pokes tongue out at the changelog). >
This fixes i.e.: long hang while loading TPM driver, if TPM chip starts in "Idle" state instead of "Ready" state. Without this patch - 'modprobe' may hang for 30 seconds or more. Please, push this patch into 2.6.27.
Marcin
| |