Messages in this thread | | | Date | Thu, 11 Sep 2008 20:56:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table |
| |
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ingo Molnar wrote: > > the false positive should be avoided, for example by unmapping the > > 'prev' mapping shortly before the leak check. > > > > Yep. I'll make it unmap just before setting acpi_gbl_permanent_mmap, > which is when it switches to using plain old ioremap. > > >> (All those other backtraces are just informational, right?) > >> > > > > no, they cause hard failures in my test setup. Nor do we want to litter > > the bootup log with messages that are not correct. > > > > No, I mean that early_ioremap_debug causes all early_ioremap()s to > dump a stack trace, so most of the stack dumps in the boot log are > diagnostic/informational rather than indications of lots of problems.
ah - now i understand what you mean, sure. The only non-diagnostic message that the test barfed on was the leak warning itself. The others were there because i did a second boot with the diagnostic messages enabled as well. (so that there's a full track of what is mapped where)
Ingo
| |