Messages in this thread | | | Date | Wed, 10 Sep 2008 14:53:47 +0400 | From | "Cyrill Gorcunov" <> | Subject | Re: [PATCH] x86: io-apic - get rid of __DO_ACTION macro |
| |
On Wed, Sep 10, 2008 at 1:31 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * Yinghai Lu <yhlu.kernel@gmail.com> wrote: > >> On Tue, Sep 9, 2008 at 11:02 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote: >> > On Wed, Sep 10, 2008 at 12:13 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote: >> > ... >> >> >> >> hope we can keep using MACRO.. >> >> >> >> YH >> >> >> > >> > Btw, Yinghai, what does it mean? To not touch this macro at all? >> > Or you mean about implementation issue (ie the design itself)? >> >> do not touch this macro... and may revisit after 2.6.28 > > anything you are particularly worried about? Regressions we should be > able to find pretty quickly, in a central macro like that - and the > macro is quite ugly. > > Ingo >
Btw Ingo, don't apply this patch for now - I'll simplify it a bit. I just overzealous with masks operation - 'and' and 'or' will be more then enough without checking. I think I will do it today evening so Yinghai could review it and say if he like it. Anyway the patch could be just queued to satisfy any concerns :)
| |