Messages in this thread | | | From | Nick Piggin <> | Subject | Re: [Approach #2] [RFC][PATCH] Remove cgroup member from struct page | Date | Thu, 11 Sep 2008 06:44:37 +1000 |
| |
On Wednesday 10 September 2008 11:49, KAMEZAWA Hiroyuki wrote: > On Tue, 9 Sep 2008 18:20:48 -0700 > > Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2008-09-09 > > 21:30:12]: OK, here is approach #2, it works for me and gives me really > > good performance (surpassing even the current memory controller). I am > > seeing almost a 7% increase > > This number is from pre-allcation, maybe. > We really do alloc-at-boot all page_cgroup ? This seems a big change.
It seems really nice to me -- we get the best of both worlds, less overhead for those who don't enable the memory controller, and even better performance for those who do.
Are you expecting many users to want to turn this on and off at runtime? I wouldn't expect so, but I don't know enough about them.
| |