Messages in this thread | | | From | "Yang, Sheng" <> | Subject | Re: [PATCH 1/2] x86: Move VMX MSRs to msr-index.h | Date | Wed, 10 Sep 2008 18:44:15 +0800 |
| |
On Tuesday 09 September 2008 21:47:03 Avi Kivity wrote: > Sheng Yang wrote: > > They are hardware specific MSRs, and we would use them in virtualization > > feature detection later. > > > > > > > > > > - > > -#define MSR_IA32_FEATURE_CONTROL 0x3a > > #define MSR_IA32_FEATURE_CONTROL_LOCKED 0x1 > > #define MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED 0x > > Might as well move these two bitmask definitions.
Um... I think it's better to leave them here, for the MSR_IA32_FEATURE_CONTROL is a MSR which can be put into msr-index.h, but the others are only bits of MSR...
-- regards Yang, Sheng
| |