Messages in this thread | | | Subject | Re: [PATCH 1/2] fix acpi ec read write bug | From | Zhao Yakui <> | Date | Thu, 11 Sep 2008 12:07:37 +0800 |
| |
On Thu, 2008-09-11 at 11:17 +0800, Kevin Hao wrote: > Fill in command unit of transaction_data structure, otherwise > gpe_transaction will skip read or write instruction. > > Signed-off-by: Kevin Hao <kexin.hao@windriver.com> > --- > drivers/acpi/ec.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c > index bd3555c..0c65e82 100644 > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -240,6 +240,7 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec *ec, u8 command, > } > atomic_set(&ec->irq_count, 0); > /* fill in transaction structure */ > + ec->t.command = command; It is also OK to add this explicitly. In fact the ec->t.command will be assigned in the function of acpi_ec_write_cmd.
Thanks. > ec->t.wdata = wdata; > ec->t.wlen = wdata_len; > ec->t.rdata = rdata;
| |