Messages in this thread | | | Date | Wed, 10 Sep 2008 16:00:26 -0700 (PDT) | Subject | Re: [PATCH 1/2] Traffic control cgroups subsystem | From | David Miller <> |
| |
From: "Ranjit Manomohan" <ranjitm@google.com> Date: Wed, 10 Sep 2008 15:56:55 -0700
> That is correct for ingress, for egress the sk is already available in > the skb so should be fine.
That is not something you can rely upon, even for egress, %100 of the time.
Some forms of reallocation and mangling might decide to orphan the SKB and thus drop the skb->sk reference before you see the packet. And they are absolutely free to do this.
Just grep for skb_orphan().
Therefore, it is absolutely something you should not rely upon for correct operation.
Like I said from the beginning, Thomas's approach is the superior one.
| |