Messages in this thread | | | Date | Wed, 10 Sep 2008 08:39:00 -0500 | From | Eric Sandeen <> | Subject | Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h |
| |
Kirill A. Shutemov wrote: > On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote: >> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote: >>> On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote: >>>> On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote: >>>>> linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h >>>> And who cares? > > Do you think it isn't error? > >>> It breaks building pam_mktemp at least. >> pam_mktemp should not use <linux/ext2_fs.h>, but rather >> <ext2fs/ext2_fs.h>.
That's right.
> Why linux/ext2_fs.h does export to userspace? >
it does?
$ grep header-y include/linux/Kbuild | wc -l 163 $ grep header-y include/linux/Kbuild | grep ext2 $
I think it does not.
-Eric
| |