Messages in this thread | | | Date | Tue, 09 Sep 2008 22:59:31 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [RFC/PATCH] i386: handle all exceptions with interrupts off initially |
| |
Ingo Molnar wrote: > > the entry paths here are really short (we enable irqs almost > immediately) so it's a non-issue in terms of worst-case latencies. > >> In other words, it's not something we want to do "just because", but >> to the extent that it provides real benefit, it makes sense. > > this is historically pretty fragile code so bringing the 32-bit and > 64-bit variants more in line sounds like a good reason to me. For > example we had various long-living irq state annotation bugs (the > combination of kprobes and lockdep, etc.) that remained unfixed partly > due to this assymetry. >
Agreed completely. I certainly didn't mean to come across sounding negative.
-hpa
| |