lkml.org 
[lkml]   [2008]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] fix watchdog/wdt285.c compilation
On Fri, Aug 08, 2008 at 07:03:46PM +0300, Adrian Bunk wrote:
> wdt285.c:211: error: 'KERN_WARN' undeclared (first use in this function)

It might be worth having the kernel provide an alias for KERN_WARN
to avoid these kinds of errors in the future. Many people have
said that they make this mistake as well, I certainly have many a
time.

The problem is that we have things like KERN_ERR, KERN_CRIT rather
than KERN_ERROR and KERN_CRITICAL, but so we think "oh, we're using
shortened versions" but then you come to KERN_WARNING rather than
KERN_WARN.

However, since xxx_WARNING is a recognised name for the severity
level (see syslog(3)) we shouldn't get rid of that.

Needless to say, this fix for wdt285 still needs to get to Linus ASAP.

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:


\
 
 \ /
  Last update: 2008-08-09 12:09    [W:0.044 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site