Messages in this thread | | | Date | Sat, 9 Aug 2008 19:01:54 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH 3/3] PCI: Add pci_read_base() API |
| |
On Sat, Aug 09, 2008 at 06:47:50PM -0600, Grant Grundler wrote: > This would be a suitable comment in the code. > My point still stands: The next person modifying the code will > need to know how/what to test and where to look it up.
It turns out Eric doesn't need this code after all. So we have no users, and this patch (3/3) isn't going into the tree. 1/3 and 2/3 are already in, and make the code easier to follow while adding no additional functionality.
-- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |