Messages in this thread Patch in this message | | | Subject | Re: [PATCH 2/2] Repost Cell OProfile: SPU mutex lock fix, version 4 | From | Carl Love <> | Date | Fri, 08 Aug 2008 15:39:44 -0700 |
| |
Updated to address Arnd's comments.
If an error occurs on opcontrol start, the event and per cpu buffers are released. If later opcontrol shutdown is called then the free function will be called again to free buffers that no longer exist. This results in a kernel oops. The following changes prevent the call to delete buffers that don't exist.
Signed-off-by: Carl Love <carll@us.ibm.com>
Index: Cell_kernel_6_26_2008/drivers/oprofile/cpu_buffer.c =================================================================== --- Cell_kernel_6_26_2008.orig/drivers/oprofile/cpu_buffer.c +++ Cell_kernel_6_26_2008/drivers/oprofile/cpu_buffer.c @@ -38,8 +38,10 @@ void free_cpu_buffers(void) { int i; - for_each_online_cpu(i) + for_each_online_cpu(i) { vfree(per_cpu(cpu_buffer, i).buffer); + per_cpu(cpu_buffer, i).buffer = NULL; + } } unsigned long oprofile_get_cpu_buffer_size(void) Index: Cell_kernel_6_26_2008/drivers/oprofile/event_buffer.c =================================================================== --- Cell_kernel_6_26_2008.orig/drivers/oprofile/event_buffer.c +++ Cell_kernel_6_26_2008/drivers/oprofile/event_buffer.c @@ -93,6 +93,8 @@ out: void free_event_buffer(void) { vfree(event_buffer); + + event_buffer = NULL; }
| |