Messages in this thread | | | Date | Fri, 08 Aug 2008 14:55:41 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] PNP: make the resource type an unsigned long |
| |
Rene Herman wrote: > Hi Bjorn. > > Andrew earlier commented that pci_resourec_flags() returns an unsigned > long. Had this hanging around a local branch. Useful? >
-int pnp_resource_type(struct resource *res) +unsigned long pnp_resource_type(struct resource *res) { return res->flags & (IORESOURCE_IO | IORESOURCE_MEM | IORESOURCE_IRQ | IORESOURCE_DMA); }
Seems a bit pointless ... either one of those flags is >= 32 bits, in which case we need u64, or it's not, in which case there is no reason to burden the output with bits we don't need.
-hpa
| |