Messages in this thread | | | Date | Fri, 8 Aug 2008 14:03:47 -0400 | From | Dave Jones <> | Subject | Re: [PATCH -next] powernow-k8: fix build errors |
| |
On Fri, Aug 08, 2008 at 10:50:40AM -0700, Randy Dunlap wrote: > On Fri, 8 Aug 2008 13:38:22 -0400 Dave Jones wrote: > > > I think something like below may be better.. > > Same thing, but with one less ifdef ? > > Close, but no cigar.
Yeah, that's what you get for posting before building.
> > diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c > > index 7a09ba4..3ba6fd2 100644 > > --- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c > > +++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c > > @@ -951,6 +951,7 @@ static void powernow_k8_cpu_exit_acpi(struct powernow_k8_data *data) > > } > > > > #else > > +static int powernow_k8_cpu_preinit_acpi(struct powernow_k8_data *data) { return -ENODEV; } > (void) // parameters
I made the same change locally.
> (your) new patch:
I'll punt this on to Linus with your Signed-off-by: and Marks ACKed by.
thanks,
Dave
-- http://www.codemonkey.org.uk
| |