lkml.org 
[lkml]   [2008]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: possible recursive locking in udp4_lib_rcv
On Fri, Aug 08, 2008 at 10:28:41PM +0800, Herbert Xu wrote:
>
> @@ -1165,7 +1189,13 @@ int __udp4_lib_rcv(struct sk_buff *skb, struct hlist_head udptable[],
> inet_iif(skb), udptable);
>
> if (sk != NULL) {
> - int ret = udp_queue_rcv_skb(sk, skb);
> + int ret = 0;
> + bh_lock_sock_nested(sk);
> + if (!sock_owned_by_user(sk))
> + ret = udp_queue_rcv_skb(sk, skb);
> + else
> + sk_add_backlog(sk, skb);
> + bh_unlock_sock(sk);
>
> Hmm, what was the reason for that lock?

Never mind, I see the reason why it's there. What we should do
is drop the lock when we hit an encapsulated socket since they
don't need it at all.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2008-08-08 16:41    [W:1.025 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site