Messages in this thread Patch in this message | | | From | Johannes Weiner <> | Subject | Re: [PATCH] ftrace: printk formatting infrastructure fix 2 | Date | Fri, 08 Aug 2008 12:47:52 +0200 |
| |
Hi Andrew,
[sorry, screwed up the recpt list before....]
Johannes Weiner <hannes@saeurebad.de> writes:
> Hi, > > akpm@linux-foundation.org writes: > >> ftrace-new-continue-entry-separate-out-from-trace_entry.patch >> ftrace-printk-formatting-infrastructure.patch > > --- > The attribute on the function definition breaks compilation. Instead of > removing it, we could use a declaration and add the attribute there, but > then, when someone adds new ftrace_printk()s, she will probably compile > with CONFIG_TRACING and the callsite is garuanteed to be verified during > development. > > Signed-off-by: Johannes Weiner <hannes@saeurebad.de> > --- > include/linux/ftrace.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -165,7 +165,7 @@ __ftrace_printk(unsigned long ip, const > static inline void > ftrace_special(unsigned long arg1, unsigned long arg2, unsigned long arg3) { } > static inline int > -ftrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 0))) > +ftrace_printk(const char *fmt, ...) > { > return 0; > }
Still needed, get this with mmotm-2008-08-08-00-56 and !CONFIG_TRACING:
In file included from kernel/sched.c:74: include/linux/ftrace.h:169: error: expected ‘,’ or ‘;’ before ‘{’ token make[1]: *** [kernel/sched.o] Error 1 make: *** [kernel] Error 2
Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |