Messages in this thread | | | Date | Thu, 7 Aug 2008 17:55:52 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH -next] drm: sis depends on FB_SIS |
| |
On Fri, 8 Aug 2008 00:09:42 +0100 (IST) Dave Airlie wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com> > > cc: airlied@linux.ie > > > > drm/sis calls mm functions in fb/sis, so make the former depend > > on the latter. > > > > This one happened with FB_SIS=m, AGP_SIS=y, DRM_SYS=y. > > > > sis1.out:sis_mm.c:(.text+0x70014): undefined reference to `sis_free' > > sis1.out:sis_mm.c:(.text+0x7002a): undefined reference to `sis_malloc' > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > NAK but I've no idea what the right answer is.
I sort of expected a NAK. Is OK.
> If someone asks for sisfb then sis drm uses code from it, if they don't > ask for it it doesn't. So I want sisfb to be built in if its selected and > sis drm is built-in.
config DRM_SIS select FB_SIS
might do it.
> Maybe I should just rip the dependency out completely, but this patch will > break stuff badly, if someone was using the SIS DRM without sisfb. > > Dave. > > > --- > > drivers/gpu/drm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-next-20080806.orig/drivers/gpu/drm/Kconfig > > +++ linux-next-20080806/drivers/gpu/drm/Kconfig > > @@ -86,7 +86,7 @@ config DRM_MGA > > > > config DRM_SIS > > tristate "SiS video cards" > > - depends on DRM && AGP > > + depends on DRM && AGP && FB_SIS > > help > > Choose this option if you have a SiS 630 or compatible video > > chipset. If M is selected the module will be called sis. AGP
--- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/
| |