Messages in this thread | | | Date | Wed, 6 Aug 2008 13:45:22 -0700 | From | Arjan van de Ven <> | Subject | Re: [patch 3/5] [PATCH 3/5] x86: Run Intel ucode-updates via workqueue. |
| |
On Wed, 06 Aug 2008 13:31:18 -0700 Max Krasnyansky <maxk@qualcomm.com> wrote:
> Arjan van de Ven wrote: > > On Wed, 6 Aug 2008 17:21:20 +0200 > > Peter Oruba <peter.oruba@amd.com> wrote: > > > > [ no description or reason ] > > > > Why is this? > > > > I'm not very happy about this.. it means practically that this stuff > > *has* to run late. Probably later than we want to. > > (Like.. we may want to redo the microcode during resume.. which is > > not a schedulable context) > > Dmitry and I tried to figure out how soon does it need to run.
you're not going to like the answer, but it's "as soon as possible". Unlike normal boot, hotplug is a case where the bios hasn't been able to put a normal microcode in.
> Nobody had a strong argument why it must run synchronously in the > hotplug path.
Ok we as Intel really want it as early as possible.
> Sure we want it as soon as possible and I'd say > workqueue is soon enough. > Existing hotplug path does not guaranty any ordering and original > microcode interface was driven from user-space. So clearly it was not > considered very critical.
well that's why it changed to no longer use the userspace driven thing..
> > Max
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |