Messages in this thread | | | Date | Tue, 5 Aug 2008 17:59:37 -0400 | From | Sean MacLennan <> | Subject | Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti |
| |
On Tue, 5 Aug 2008 14:37:19 -0700 (PDT) "Linus Torvalds" <torvalds@linux-foundation.org> wrote:
> On Tue, 5 Aug 2008, Sean MacLennan wrote: > > > > Why not select PIO or MMIO at config time? > > Umm. Then you can't run a generic driver that can do either. That's > the worst choice of all.
But do we really need a generic driver that can do either? Maybe for the current mISDN driver, but when you get to other chip ports, say the xhfc, you have to select the low level interface at compile time. Or I should say you currently have to select at config time.
I'm not arguing that we *have* to do it this way. I just don't think we should throw out the simplest method without some thought. There is some precedence for a config time option, for example the 8139too ethernet driver.
Cheers, Sean
| |