lkml.org 
[lkml]   [2008]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] Fix remaining big endian issue of hfcmulti


On Tue, 5 Aug 2008, Karsten Keil wrote:
>
> Maybe we can use the trick from lib/iomap.c to detect which
> kind of IO is needed, but unfortunately PIO_OFFSET, PIO_MASK and
> PIO_RESERVED are not exported so it would need to copy the defines, which
> isn't a really clean solution.

Even if they were exported, you couldn't.

lib/iomap.c is _not_ generic code. It's a library function for
architectures that don't do it some other way. But various architectures
can choose to not use lib/iomap.c at all - for example, they may have MMIO
and PIO in the same address space, so they don't need the conditionals at
all (because all the work was done at mapping time, not at runtime).

So if you actually have different models of operation for PIO and MMIO,
then yes, you need to handle that in the driver itself.

Linus


\
 
 \ /
  Last update: 2008-08-05 20:45    [W:0.076 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site