Messages in this thread | | | Date | Tue, 05 Aug 2008 17:57:18 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH] Make kthread_stop() not oops when passed a bad pointer |
| |
Matthew Wilcox wrote: > --- a/kernel/kthread.c > +++ b/kernel/kthread.c > @@ -201,6 +201,9 @@ int kthread_stop(struct task_struct *k) > { > int ret; > > + if (!k || IS_ERR(k)) > + return -EINVAL; > + > mutex_lock(&kthread_stop_lock); > > /* It could exit after stop_info.k set, but before wake_up_process. */
Would if (WARN_ON(!k || IS_ERR(k)))
be in order, or are there valid cases of passing an invalid pointer? -- Stefan Richter -=====-==--- =--- --=-= http://arcgraph.de/sr/
| |