lkml.org 
[lkml]   [2008]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Make kthread_stop() not oops when passed a bad pointer
Matthew Wilcox wrote:
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -201,6 +201,9 @@ int kthread_stop(struct task_struct *k)
> {
> int ret;
>
> + if (!k || IS_ERR(k))
> + return -EINVAL;
> +
> mutex_lock(&kthread_stop_lock);
>
> /* It could exit after stop_info.k set, but before wake_up_process. */

Would
if (WARN_ON(!k || IS_ERR(k)))

be in order, or are there valid cases of passing an invalid pointer?
--
Stefan Richter
-=====-==--- =--- --=-=
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2008-08-05 18:01    [W:1.005 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site