Messages in this thread | | | Date | Mon, 04 Aug 2008 19:15:55 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c |
| |
Paolo Ciarrocchi wrote: > > _much worse_? Wow, I thought the opposite. > Anyway, that's just a coding style patch, feel free to simply not apply it as > it's really a matter of personal taste but be sure that I'm not > blindly changing the code > accordingly to checkpatch. That might be almost true when I started > doing this kind of patches months > ago but it's definitely not true anymore. >
In this case, the real problem is that the original code used a switch statement where it really should have used a table.
-hpa
| |