lkml.org 
[lkml]   [2008]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.27-rc1 6/25] mdb: Merkey's Kernel Debugger 2.6.27-rc1
jmerkey@wolfmountaingroup.com wrote:
> --- a/debug/mdb.c 1969-12-31 17:00:00.000000000 -0700
> +++ b/debug/mdb.c 2008-08-03 16:15:00.000000000 -0600
[...]
> +ULONG ScreenInputFromKeyboard(BYTE *buf, ULONG buf_index, ULONG max_index)
> +{
[...]
> + HistoryIndex = HistoryPointer;
> + while (1)
> + {
> + key = mdb_getkey();
> +
> + if ((IsAccelerator(key)) && (key != 13))
> + return key;
> +
> + switch (key)
> + {
[...]
> + default:
> + if ((key > 0x7E) || (key < ' ')) // if above or below text
> + break;
> + else
> + {
> + if (strlen(buf) < max_index)
> + {
> + register int delta;
> +
> + for (i=max_index; i > buf_index; i--)
> + buf[i] = buf[i-1];
> + buf[buf_index] = (BYTE)key;
> + if (buf_index < max_index)
> + buf_index++;
> +
> + delta = strlen(buf) - buf_index;
> +
> + for (i=0; (i < delta) && (buf[i]); i++)
> + DBGPrint("%c", buf[buf_index + i]);
> +
> + for (i=0; i < delta; i++)
> + DBGPrint("\b");
> + }
> + }
> + break;
> + }
> + }
> +}

This function would benefit from being broken up into smaller ones.
--
Stefan Richter
-=====-==--- =--- --=--
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2008-08-04 16:21    [W:0.022 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site