lkml.org 
[lkml]   [2008]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 14/20] parisc: use the new byteorder headers
    From
    Date
    On Fri, 2008-08-01 at 17:18 -0600, Grant Grundler wrote:
    > On Fri, Aug 01, 2008 at 02:23:37PM -0700, Harvey Harrison wrote:
    > ...
    > > > Should this only be defined if BITS_PER_LONG is <=32 ?
    > >
    > > The new byteorder headers only uses this if no __arch_swab64 is defined.
    > >
    > > Further down in the parisc version, an __arch_swab64 is defined in the
    > > BITS_PER_LONG >=32 case, making this moot.
    >
    > Ok.
    >
    > ...
    > > Other than the endianness, any other concerns?
    >
    > Have you had a chance to test this?

    le-only personally (X86-32).

    > Or can you point me at another big endian arch that has similar
    > use of header files that has been successfully tested?

    AVR32 got a maintainer ack, I'm assuming that was tested. It's not
    functionally any different than the existing code really, other
    than allowing compile-time folding in the cpu_to_{endian} helpers.

    Mips was also acked, but that can be little or big endian.

    >
    > I can arrange for access to parisc HW if you have time/interest
    > in testing this yourself.

    Sure, drop me a note.

    Harvey



    \
     
     \ /
      Last update: 2008-08-04 08:05    [W:6.002 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site