Messages in this thread Patch in this message | | | Date | Mon, 04 Aug 2008 08:36:38 -0500 | From | Christoph Lameter <> | Subject | Re: [patch 15/19] Filesystem: XFS slab defragmentation |
| |
Dave Chinner wrote:
> I think that hunk is mis-applied. You're configuring the > xfs_vnode_zone defrag after allocating the xfs_ioend_zone. This > should be afew lines higher up, right?
That would be nicer but its not a bug to have the setup where it is right now.
Fix:
Subject: defrag/xfs: Move defrag setup directly after xfs_vnode_zone kmem cache creation
Move the setup of the defrag directly after the creation of the xfs_vnode_zone
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Index: linux-2.6/fs/xfs/linux-2.6/xfs_super.c =================================================================== --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_super.c 2008-08-04 08:27:09.000000000 -0500 +++ linux-2.6/fs/xfs/linux-2.6/xfs_super.c 2008-08-04 08:27:25.000000000 -0500 @@ -2021,11 +2021,11 @@ if (!xfs_vnode_zone) goto out;
+ kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes); + xfs_ioend_zone = kmem_zone_init(sizeof(xfs_ioend_t), "xfs_ioend"); if (!xfs_ioend_zone) goto out_destroy_vnode_zone; - kmem_cache_setup_defrag(xfs_vnode_zone, get_inodes, kick_inodes); - xfs_ioend_pool = mempool_create_slab_pool(4 * MAX_BUF_PER_PAGE, xfs_ioend_zone); if (!xfs_ioend_pool)
| |