Messages in this thread | | | Date | Sat, 30 Aug 2008 23:24:29 +0100 | From | Simon Arlott <> | Subject | Re: [PATCH] scsi/sd: Fix size output in MB |
| |
On 30/08/08 23:13, Pierre Ossman wrote: > On Sat, 30 Aug 2008 16:45:49 -0500 > James Bottomley <James.Bottomley@HansenPartnership.com> wrote: > >> On Sat, 2008-08-30 at 22:59 +0200, Pierre Ossman wrote: >> > On Sat, 30 Aug 2008 11:45:16 -0600 >> > Matthew Wilcox <matthew@wil.cx> wrote: >> > >> > > >> > > 2. We should report in GB or TB when appropriate. The exact definition >> > > of 'appropriate' is going to vary from person to person. Might I >> > > suggest that we should report between two and four significant digits. >> > > eg 9543 MB is ok, 10543 MB should be 10 GB. >> > > >> > >> > I've been looking at doing something like this for the mmc_block >> > driver, so a generic helper is welcome. :) >> >> Does MMC have the 10^3 requirement like SCSI/ATA disks do, or can you >> use 2^10 like standard computer stuff for capacities? >> > > Some do, some don't. I prefer the 2^10 and MiB variants as it avoids > ambiguity.
If there's a generic function to do this, there could be a Kconfig option to select the variant (10^3 MB, 2^10 MiB, 2^10 MB ;)), as long as the byte value is available from the same message.
-- Simon Arlott
| |