lkml.org 
[lkml]   [2008]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ne.c fix, res->name
On Sun, Aug 31, 2008 at 12:03:57AM +0900, Atsushi Nemoto wrote:
> On Fri, 29 Aug 2008 21:44:25 -0500, David Fries <david@fries.net> wrote:
> > + if (!strcmp(res->name, BAD_STR))
> > + dev->mem_end = BAD;
>
> The res->name might be NULL. You should check it first.
>
> if (res->name && !strcmp(res->name, BAD_STR))
> dev->mem_end = BAD;

The name gets a valid string by that point in time.

drivers/base/platform.c:257
int platform_device_add(struct platform_device *pdev)

for (i = 0; i < pdev->num_resources; i++) {
struct resource *p, *r = &pdev->resource[i];

if (r->name == NULL)
r->name = pdev->dev.bus_id;

--
David Fries <david@fries.net>
http://fries.net/~david/ (PGP encryption key available)


\
 
 \ /
  Last update: 2008-08-30 20:07    [W:0.054 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site