lkml.org 
[lkml]   [2008]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] utrace core
1. UTRACE_ATTACH_MATCH_DATA is not used.

2. s/utrace_attached_engine/utrace_engine/g

Engine which is not attached is either just allocated or scheduled
for freeing

3. get_utrace_lock() is funny.

From name one should get valid struct utrace or -E depending only on
task, why engine matters is a mystery.

4. subsys_initcall

Just use module_init() or comment why it's needed.

5. Dummy in examiner -- not used (of course!)



\
 
 \ /
  Last update: 2008-08-27 22:05    [W:0.194 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site