Messages in this thread | | | Date | Tue, 26 Aug 2008 15:40:48 -0700 | From | "Paul Menage" <> | Subject | Re: [PATCH] cgroup(fix critical bug): new handling for tasks file |
| |
On Mon, Aug 25, 2008 at 10:22 PM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote: >> But improving the current code has been on my todo list for a while. >> My thought on the best way to fix it is to use a proper seq_file - >> that would remove the issues that you have currently with the >> "unconsumed" portion of the output. > > But for my poor knowledge we always have to handle "unconsumed portion" > for nonseekable file in all different way. In my binary search based > solving, I have to handle unconsumed part for a pid and bring in > some complicated. This is really a disadvantage as you pointed out.
I meant that the seq_file code could handle the "unconsumed" portion for you, rather than you having to manage it explicitly.
Paul
| |