Messages in this thread | | | Subject | Re: [PATCH 1 of 3] add phys_addr_t for holding physical addresses | From | Benjamin Herrenschmidt <> | Date | Sun, 24 Aug 2008 19:39:58 +1000 |
| |
.../...
> diff --git a/include/asm-x86/page_32.h b/include/asm-x86/page_32.h > --- a/include/asm-x86/page_32.h > +++ b/include/asm-x86/page_32.h > @@ -33,7 +33,6 @@ > typedef u64 pudval_t; > typedef u64 pgdval_t; > typedef u64 pgprotval_t; > -typedef u64 phys_addr_t;
.../...
Might sound a stupid question, but why have a CONFIG_ option and a global definition based on it rather than each arch defining it as part of the base types ? I don't have a firm preference for one or the other at this point, I can see pro and cons to both approach, so I'm curious to see what others think about it.
Cheers, Ben.
| |