lkml.org 
[lkml]   [2008]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] readdir mess


On Sun, 24 Aug 2008, Al Viro wrote:
>
> One obvious note: that'll break old_readdir() on coda. There you need to
> change the existing check (you need to check buf.result, then ignore error
> unless buf.result ended up 0).

Hmm? old_readdir() was the only one that I didn't change, because it
didn't need changing. It already ignores the return value of
"vfs_readdir()" entirely if it is positive or zero, and takes it from
buf.result.

So old_readdir() literally doesn't care at all (and never has) whether a
->readdir() function returns zero or a positive number. So changing coda
readdir() it to return zero _instead_ of a positive number makes
absolutely zero difference: old_readdir() will do the same thing
regardless.

What am I missing?

Linus


\
 
 \ /
  Last update: 2008-08-24 19:23    [W:0.064 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site