lkml.org 
[lkml]   [2008]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: latest -git: WARNING: at arch/x86/kernel/ipi.c:123 send_IPI_mask_bitmask+0xc3/0xe0()
> We still need the equivalent functionality, though.  The midlayer 
> (msr_on_cpu) may be pointless, but that doesn't change the fact that
> putting this functionality in the lower layer (smp_call_function_single)
> makes more sense.

Assuming you can actually have interrupts enabled at these point
and be otherwise ready to do call_function_simple (e.g. cpu hotplug
locking etc.)

For a lot of MSR accesses in more complicated subsystems like cpufreq
that requires complications. I would think for many circumstances it's
better to simply set affinity of the thread before at a higher level.

In hindsight I think it was my mistake to ever merge that.
I admit I never liked it, but just merged it because I wasn't able
to come up with a strong enough counter argument back then.

-Andi


\
 
 \ /
  Last update: 2008-08-22 11:35    [W:0.142 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site