Messages in this thread | | | Date | Fri, 22 Aug 2008 06:31:39 -0500 | From | Jack Steiner <> | Subject | Re: [PATCH] x86: silence section mismatch warning - uv_cpu_init |
| |
On Fri, Aug 22, 2008 at 08:19:01AM +0200, Ingo Molnar wrote: > > * Marcin Slusarz <marcin.slusarz@gmail.com> wrote: > > > From: Marcin Slusarz <marcin.slusarz@gmail.com> > > Subject: [PATCH v2] x86: fix section mismatch warning - uv_cpu_init > > > > WARNING: vmlinux.o(.cpuinit.text+0x3cc4): Section mismatch in reference from the function uv_cpu_init() to the function .init.text:uv_system_init() > > The function __cpuinit uv_cpu_init() references > > a function __init uv_system_init(). > > If uv_system_init is only used by uv_cpu_init then > > annotate uv_system_init with a matching annotation. > > > > uv_system_init was ment to be called only once, so do it from codepath > > (native_smp_prepare_cpus) which is called once, right before activation > > of other cpus (smp_init). > > > > Note: old code relied on uv_node_to_blade being initialized to 0, > > but it'a not initialized from anywhere. > > thanks - applied it to tip/x86/urgent. Jack, any objections?
Looks good. Thanks.
Acked-by: Jack Steiner <steiner@sgi.com>
--- jack
| |