Messages in this thread | | | Subject | Re: [PATCH 03/10] AXFS: axfs.h | From | Daniel Walker <> | Date | Thu, 21 Aug 2008 06:10:58 -0700 |
| |
On Wed, 2008-08-20 at 22:45 -0700, Jared Hulbert wrote: > +#define AXFS_GET_BYTETABLE_VAL(desc,index) \ > + axfs_bytetable_stitch(((struct > axfs_region_desc)(desc)).table_byte_depth,\ > + (u8 *)((struct axfs_region_desc)(desc)).virt_addr, index) > + > +#define AXFS_GET_NODE_TYPE(sbi,node_index) \ > + AXFS_GET_BYTETABLE_VAL(((struct axfs_super *)(sbi))->node_type,\ > + (node_index)) > + > +#define AXFS_GET_NODE_INDEX(sbi,node__index) \ > + AXFS_GET_BYTETABLE_VAL(((struct axfs_super *)(sbi))->node_index,\ > + (node__index)) > +
I think it would be much cleaner to do all these similar macro's as static inline functions.
Daniel
| |