Messages in this thread | | | Date | Thu, 21 Aug 2008 15:02:59 +0200 | From | Ingo Molnar <> | Subject | Re: patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug |
| |
* Jan Beulich <jbeulich@novell.com> wrote:
> Converting __cpuinit functions called out of init_amd() (and similar > others) to __init (and making them subject of xxx_initcall() handling > isn't valid, as they would no longer be called for hot plugged CPUs. > > Further, since it's likely that in virtualized environments the MSR > write would at best be ignored, I'd also recommend using the > fault-safe accessors here *and* check that the bit actually got set > before setting PCI_HAS_IO_ECS (one would obviously have to BUG() when > hot-plugged CPUs fail to set the bit when those available at boot > successfully did so).
hm, which patch is this exactly, and in what tree? It's not upstream nor in -tip.
Ingo
| |