Messages in this thread | | | Date | Sat, 2 Aug 2008 20:53:32 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [RFC, 2.6.26.2-rc1] exec: remove some includes |
| |
On Sat, 2 Aug 2008, Linus Torvalds wrote: > On Sat, 2 Aug 2008, Oliver Pinter wrote: > > > > [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ] > > > > fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did > > mm-ish stuff in install_arg_page(); but no need for them after 2.6.22. > > Why on earth would this be -stable material?
Of course it isn't -stable material, I don't know what Oliver's on.
Maybe he noticed akpm's "unbreak arm" comment and thought it was fixing some pre-existing breakage: no, akpm restored swap.h to fix the arm build. Then after this commit, we had to restore pagemap.h to fix avr32 and !CONFIG_SWAP builds.
Prime material for -unstable, I'm ashamed to say.
Hugh
| |