lkml.org 
[lkml]   [2008]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] ide: add a driver-wide debugging macro
From
Date
On Sun, 2008-08-17 at 19:23 +0200, Borislav Petkov wrote:
> diff --git a/include/linux/ide.h b/include/linux/ide.h
> index c161840..b6d714d 100644
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> []
> +/* DRV_NAME has to be defined in the driver before using the macro below */
> +#define __ide_debug_log(lvl, fmt, args...) \
> +{ \
> + if (unlikely(drive->debug_mask & lvl)) \
> + printk(KERN_INFO DRV_NAME ": " fmt, ## args); \
> +}

Shouldn't a debug printk use KERN_DEBUG?



\
 
 \ /
  Last update: 2008-08-17 20:15    [W:0.147 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site