Messages in this thread | | | From | Rusty Russell <> | Subject | Re: Core kernel parameters and /sys/parameters? | Date | Fri, 15 Aug 2008 09:32:43 +1000 |
| |
On Friday 15 August 2008 08:25:22 Greg KH wrote: > On Thu, Jul 31, 2008 at 01:59:02PM +1000, Rusty Russell wrote: > > Hi Greg, > > > > Was looking at implementing "core_param" for things like > > "initcall_debug" (ie. params with no prefix), and wanted to put them in > > sysfs of course. I hacked in a new "kernel" dir, but > > /sys/module/kernel/parameters/ is a bit of an odd place for it to end up > > in. > > > > I noticed this comment in params.c: > > > > * /sys/module/[mod->name]/parameters to /sys/parameters/[mod->name]/ > > > > I like the idea of /sys/parameters/ much better (perhaps even with core > > parameters at the top level). Is this obsolete? Planned? > > Did I write that comment? I sure don't remember it, sorry :) > > I don't have any plans on changing this, but I do know people use the > /sys/module/MODULE_NAME/parameters interface today, why change it?
Well mainly that many of them aren't modules, so if a change was planned for some other reason I'd support it.
And as I said, having core parameters (ie. converting things which are current __setup) appear in /sys/module/kernel/parameters/ is a bit strange.
Cheers, Rusty.
| |