Messages in this thread | | | Date | Thu, 14 Aug 2008 15:15:02 -0700 (PDT) | Subject | Re: [RFC][PATCH] netconsole: avoid deadlock on printk from driver code | From | David Miller <> |
| |
From: Pekka J Enberg <penberg@cs.helsinki.fi> Date: Thu, 14 Aug 2008 16:44:32 +0300 (EEST)
> @@ -598,6 +598,7 @@ > > spinlock_t lock; > spinlock_t rx_lock; > + spinlock_t tx_lock; > > chip_t chipset; > u32 rx_config;
Why create a special purpose lock when the generic networking already is taking a lock for you to proect the TX path?
Furthermore, as I just described in another reply, netpoll already knows that it might need to trylock() attempt on this lock in order to avoid the very deadlocks this thread is about.
| |