lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 7/8] x86: apic - unify sync_Arb_IDs
That happend sendmail/quilt sent mail by past :(. I'll fix and resend
tomorrow. thanks.

On 8/14/08, Maciej W. Rozycki <macro@linux-mips.org> wrote:
> On Thu, 1 Jan 1970, Cyrill Gorcunov wrote:
>
> Hmm, are you living in the past?
>
>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>> ---
>>
>> diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
>> index 1d5f830..ec0f18f 100644
>> --- a/arch/x86/kernel/apic_32.c
>> +++ b/arch/x86/kernel/apic_32.c
>> @@ -919,8 +919,7 @@ void __init sync_Arb_IDs(void)
>> apic_wait_icr_idle();
>>
>> apic_printk(APIC_DEBUG, "Synchronizing Arb IDs.\n");
>> - apic_write(APIC_ICR,
>> - APIC_DEST_ALLINC | APIC_INT_LEVELTRIG | APIC_DM_INIT);
>> + apic_write(APIC_ICR, APIC_DEST_ALLINC | APIC_INT_LEVELTRIG |
>> APIC_DM_INIT);
>> }
>>
>> /*
> [etc...]
>
> Well, I think this one is backwards... There are exceptions, but the
> general rule is to with within the width of the terminal.
>
> Maciej
>


\
 
 \ /
  Last update: 2008-08-14 22:13    [W:0.037 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site