lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 01/01][retry 3] x86: L3 cache index disable for 2.6.26
Date
From
> > > > +        val |= 0xc0000000;
> > > > + pci_write_config_dword(dev, 0x1BC + index * 4, val
> > > & ~0x40000000);
> > > > + wbinvd();
> > > > + pci_write_config_dword(dev, 0x1BC + index * 4, val);
> > >
> > > Should it do if capable() test before doing such stuff?
> >
> > I don't think so. If it got this far, it is an AMD processor
> > from family 0x10 or later, so it has wbinvd().
>
> No, I meant we should check for permissions. Filesystem permissions
> are traditionaly not enough for stuff like this. if
> (capable(CAP_ADMIN)) or something?

I see what you mean. I'll add a check again capable(CAP_SYS_ADMIN).

-Mark Langsdorf
Operating System Research Center
AMD



\
 
 \ /
  Last update: 2008-08-14 18:45    [W:0.043 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site