Messages in this thread | | | Subject | RE: [PATCH 01/01][retry 3] x86: L3 cache index disable for 2.6.26 | Date | Thu, 14 Aug 2008 11:41:34 -0500 | From | "Langsdorf, Mark" <> |
| |
> > > > + val |= 0xc0000000; > > > > + pci_write_config_dword(dev, 0x1BC + index * 4, val > > > & ~0x40000000); > > > > + wbinvd(); > > > > + pci_write_config_dword(dev, 0x1BC + index * 4, val); > > > > > > Should it do if capable() test before doing such stuff? > > > > I don't think so. If it got this far, it is an AMD processor > > from family 0x10 or later, so it has wbinvd(). > > No, I meant we should check for permissions. Filesystem permissions > are traditionaly not enough for stuff like this. if > (capable(CAP_ADMIN)) or something?
I see what you mean. I'll add a check again capable(CAP_SYS_ADMIN).
-Mark Langsdorf Operating System Research Center AMD
| |