Messages in this thread | | | Date | Thu, 14 Aug 2008 07:04:00 -0700 | From | Greg KH <> | Subject | Re: [PATCH 01/01][retry 3] x86: L3 cache index disable for 2.6.26 |
| |
On Thu, Aug 14, 2008 at 08:43:43AM -0500, Mark Langsdorf wrote: > +#if defined(CONFIG_PCI) && defined(CONFIG_K8_NB) > +static struct pci_dev *get_k8_northbridge(int node) > +{ > + return k8_northbridges[node]; > +} > +#else > +static struct pci_dev *get_k8_northbridge(int node) > +{ > + return NULL; > +} > +#endif
This should go into the header file and not the .c file right?
It's best to keep #ifdef things in .h files.
Also, you can drop the CONFIG_K8_NB test if you do that as well, as it's already in your .h file :)
> +static ssize_t show_cache_disable(struct _cpuid4_info *this_leaf, char *buf, > + unsigned int index) > +{ > + int node = cpu_to_node(first_cpu(this_leaf->shared_cpu_map)); > + struct pci_dev *dev = get_k8_northbridge(node); > + unsigned int reg = 0; > + > + if (!this_leaf->can_disable)
Trailing space, did you run this through scripts/checkpatch.pl?
thanks,
greg k-h
| |