lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH](retry 3) invalidate caches before going into suspend
On Thu, 14 Aug 2008 08:45:04 -0500
Mark Langsdorf <mark.langsdorf@amd.com> wrote:

> When a CPU core is shut down, all of its caches need to be flushed
> to prevent stale data from causing errors if the core is resumed.
> Current Linux suspend code performs an assignment after the flush,
> which can add dirty data back to the cache.  On some AMD platforms,
> additional speculative reads have caused crashes on resume because
> of this dirty data.
>
> Relocate the cache flush to be the very last thing done before
> halting.  Tie into an assembly line so the compile will not
> reorder it.  Add some documentation explaining what is going
> on and why we're doing this.


looks good to me

Acked-by: Arjan van de Ven <arjan@linux.intel.com>


--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-08-14 16:03    [W:0.043 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site