Messages in this thread | | | Date | Wed, 13 Aug 2008 09:45:53 +0900 | Subject | Re: [PATCH 2/7] x86: add free_coherent dma_ops callback to GART driver | From | FUJITA Tomonori <> |
| |
On Tue, 12 Aug 2008 17:24:12 +0200 Joerg Roedel <joerg.roedel@amd.com> wrote:
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> > --- > arch/x86/kernel/pci-gart_64.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c > index 55cc388..18db09b 100644 > --- a/arch/x86/kernel/pci-gart_64.c > +++ b/arch/x86/kernel/pci-gart_64.c
It would be better to foil this to the first patch, I think. Any reasonable reason to add alloc_coherent and free_coherent with two separate patches?
I think that you can remove map_simple in gart (and please don't forget to remove map_simple in struct dma_mapping_ops. I think only GART uses that hook).
| |