Messages in this thread Patch in this message | | | Date | Mon, 11 Aug 2008 14:36:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] printk: robustify printk |
| |
* Ingo Molnar <mingo@elte.hu> wrote:
> > I personally prefer this printk_tick() driven one over the RCU > > driven one because it doesn't trade deadlocks. > > i've started testing it in tip/core/printk to give it some track > record - thanks Peter.
small build fixlet below.
Ingo
--------------> From 99fc8ce41d639ce46f32c4e8618e8a571858e5aa Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Mon, 11 Aug 2008 14:38:12 +0200 Subject: [PATCH] printk: robustify printk, fix MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit
fix:
include/linux/kernel.h: In function ‘printk_needs_cpu': include/linux/kernel.h:217: error: parameter name omitted
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- include/linux/kernel.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h index c9ed24c..a012579 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -201,7 +201,7 @@ extern int printk_ratelimit(void); extern bool printk_timed_ratelimit(unsigned long *caller_jiffies, unsigned int interval_msec); extern void printk_tick(void); -extern int printk_needs_cpu(int); +extern int printk_needs_cpu(int cpu); #else static inline int vprintk(const char *s, va_list args) __attribute__ ((format (printf, 1, 0))); @@ -214,7 +214,7 @@ static inline bool printk_timed_ratelimit(unsigned long *caller_jiffies, \ unsigned int interval_msec) \ { return false; } static inline void printk_tick(void) { } -static inline int printk_needs_cpu(int) { return 0; } +static inline int printk_needs_cpu(int cpu) { return 0; } #endif extern void asmlinkage __attribute__((format(printf, 1, 2))) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |