lkml.org 
[lkml]   [2008]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH][RE-SEND] drivers/isdn/i4l/isdn_common.c fix small resource leak
    From
    Date
    G'day people,


    Coverity CID: 1356 RESOURCE_LEAK


    I found a very old patch for this that was Acked but did not get applied
    https://lists.linux-foundation.org/pipermail/kernel-janitors/2006-September/016362.html


    There looks to be a small leak in isdn_writebuf_stub() in isdn_common.c,
    when copy_from_user() returns an un-copied data length (length != 0).
    The below patch should be a minimally invasive fix.

    Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
    Acked-by: Karsten Keil <kkeil@suse.de>

    diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l/isdn_common.c
    index 0f3c66d..8d8c6b7 100644
    --- a/drivers/isdn/i4l/isdn_common.c
    +++ b/drivers/isdn/i4l/isdn_common.c
    @@ -1977,8 +1977,10 @@ isdn_writebuf_stub(int drvidx, int chan, const u_char __user * buf, int len)
    if (!skb)
    return -ENOMEM;
    skb_reserve(skb, hl);
    - if (copy_from_user(skb_put(skb, len), buf, len))
    + if (copy_from_user(skb_put(skb, len), buf, len)) {
    + dev_kfree_skb(skb);
    return -EFAULT;
    + }
    ret = dev->drv[drvidx]->interface->writebuf_skb(drvidx, chan, 1, skb);
    if (ret <= 0)
    dev_kfree_skb(skb);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-07-07 12:43    [W:10.702 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site