Messages in this thread | | | Subject | Re: [PATCH] [0/9] Use 64bit x86 machine check code for 32bit too | From | Max Asbock <> | Date | Mon, 07 Jul 2008 17:00:15 -0700 |
| |
On Mon, 2008-07-07 at 14:37 -0700, H. Peter Anvin wrote: > H. Peter Anvin wrote: > > Andi Kleen wrote: > >> This patchkit uses the 64bit machine check code which is better in many > >> ways on 32bit x86 too. This is also the basis for some future machine > >> check work. > > > > Hi Andi, > > > > I tried applying your patch kit to -tip, but I'm getting build failures > > on i386; gcc-4.1.1-51.fc5.x86_64 with attached configuration. > > > > FWIW, this is rooting the branch on top of current linus. Applied on > top of tip/auto-x86-next or tip/master, the patch does not apply. > > -hpa
The patches won't apply to -tip because Venki's patch has to be backed out of mce_64.c and it looks like thread_info.h has been merged in the mean time.
I was able to apply the patches to 2.6.26-rc8 though, build it and boot it. However it turns out the build warnings about "mce_64.c:822: warning: passing argument 2 of ‘strict_strtoull’ makes integer from pointer without a cast" are justified. It looks like strict_strtoull has the last two arguments switched with respect to simple_strtoull. You get a NULL pointer dereference as soon as you write to one of the machinecheck sysfs control files.
Max
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |