lkml.org 
[lkml]   [2008]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] acpi: Disable IRQ 0 through I/O APIC for some HP systems
On Mon, 7 Jul 2008, Rafael J. Wysocki wrote:

> > Ingo, from the sequence above, I gather this code is currently in the
> > tree:
> >
> > - replace_pin_at_irq(0, 0, 0, apic1, pin1);
> > - apic1 = 0;
> > - pin1 = 0;
> >
> > Please revert the change which introduced it. While I recall posting a
> > patch which added code like this, I clearly stated it was solely for
> > diagnostics of Rafael's system and not to apply to any tree.
>
> Shouldn't the setup_timer_IRQ0_pin(apic1, pin1, cfg->vector) be removed as
> well?

Yes. The whole commit should be reverted as mentioned in the other
e-mail (it didn't even bear my sign-off mark). This would include the
line you are referring to as well. I have submitted a patch to add a
64-bit variation of replace_pin_at_irq() separately.

Maciej


\
 
 \ /
  Last update: 2008-07-07 23:41    [W:0.067 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site