lkml.org 
[lkml]   [2008]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix build error of driver/mfd/tc6393xb.c
At Mon, 7 Jul 2008 09:19:05 -0700,
David Brownell wrote:
>
> On Monday 07 July 2008, Takashi Iwai wrote:
> >
> > > The most natural fix is to have the Kconfig for PPC_MPC52xx
> > > select both GENERIC_GPIO and HAVE_GPIO_LIB.
> >
> > Yes.  I, however, still feel uneasy by the fact that the combination
> > GENERIC_GPIO=n and HAVE_GPIO_LIB=y doesn't work.  We should either fix
> > it to work or disallow the combination.
>
> As in, HAVE_GPIO_LIB depends on GENERIC_GPIO? Fine with me;
> but I'm not sure that would work. Won't Kconfig gleefully let
> the "select" succeed but not select what it depends on?

No, it's a known problem of kbuild.
You can use "select" for select. So, adding "select GENERIC_GPIO"
to HAVE_GPIO_LIB should work. But, I'm not sure whether this is the
right fix, too...

Anyway, adding GENERIC_GPIO is fine as a workaround as now. I'll
resubmit the fix patch.
I just wanted you to keep the remaining problem in mind.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-07-07 18:27    [W:0.056 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site