lkml.org 
[lkml]   [2008]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] swsusp: simplify memory_bm_find_bit()
Date
On Saturday, 5 of July 2008, Akinobu Mita wrote:
> The bit obtained by the function memory_bm_find_bit() is represented
> by addr and bit_nr. The callers of memory_bm_find_bit() just use addr
> and bit_nr as the arguments of set_bit/clear_bit/test_bit.
>
> This patch simplifies the representation of the obtained bit without
> using BM_BITS_PER_CHUNK.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Pavel Machek <pavel@suse.cz>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: linux-pm@lists.linux-foundation.org
> ---
> kernel/power/snapshot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: 2.6-git/kernel/power/snapshot.c
> ===================================================================
> --- 2.6-git.orig/kernel/power/snapshot.c
> +++ 2.6-git/kernel/power/snapshot.c
> @@ -478,8 +478,8 @@ static int memory_bm_find_bit(struct mem
> }
> zone_bm->cur_block = bb;
> pfn -= bb->start_pfn;
> - *bit_nr = pfn % BM_BITS_PER_CHUNK;
> - *addr = bb->data + pfn / BM_BITS_PER_CHUNK;
> + *bit_nr = pfn;
> + *addr = bb->data;
> return 0;
> }

Hm, I think it's better to fold that into patch 2/2.

Thanks,
Rafael


\
 
 \ /
  Last update: 2008-07-07 14:43    [W:0.047 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site